Skip to content

fix(cli): make sure arg parsers use correct defaults.#134

Merged
Davidyz merged 1 commit intomainfrom
fix/cli_parser_defaults
May 14, 2025
Merged

fix(cli): make sure arg parsers use correct defaults.#134
Davidyz merged 1 commit intomainfrom
fix/cli_parser_defaults

Conversation

@Davidyz
Copy link
Owner

@Davidyz Davidyz commented May 14, 2025

Fix #132

@Davidyz Davidyz added bug Something isn't working fix labels May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (2815496) to head (362083b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          22       22           
  Lines        1463     1464    +1     
=======================================
+ Hits         1452     1453    +1     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Davidyz Davidyz force-pushed the fix/cli_parser_defaults branch from 427769a to 362083b Compare May 14, 2025 01:37
@Davidyz Davidyz merged commit d36ef41 into main May 14, 2025
12 checks passed
@Davidyz Davidyz deleted the fix/cli_parser_defaults branch May 14, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] cli_parser default the chunk_size to -1 and that takes priority over any chunk_size value in config files

1 participant